Code Challenge Review Checklist
Opinionated Checklist for Reviewing a Code Challenge
Algorithm
BigO
Recursive Approach
Covers edge cases
Example provided matches
Return values matches
Clean Code
Production ready
No dead code
No commented code
Namespace usage
No global variables
Correct visibility modifiers
No duplicated code
No empty blocks
Correct data types or structures
Design patterns
No mixed tabs vs spaces
No Getters & Setters
Use Exceptions rather than return codes
Don't return null
Make class final if not being used for inheritance
Dependency Injection
No Dependency Cycles
Coding Style
Code linted
Respecting community standards
No issue phpcbf
No issue php-cs-fixer
Folder structure
No debug code
Complexity
No complex expressions
No bitwise operations
No magic variables
No magic values
No magic methods
Law of Demeter
No over engineered
Documentation
DocBlocks
README file
Usage
Code readability
CLI help
No TODOs
No HACKs
Logs
Unusual behaviour is commented
UML
Environment
Dockerized
Docker-compose
.env file
i18n
Translations
Language
Package manager
Version within EOL
Using most recent version
Paradigms
DRY
GRASP
Quick & dirty
SOLID
OOP
Performance
Speed
Number of loops
Presentation
Color shell
Readability
Variables names
Spelling
No double negations
No nested if, for, ...
Security
No Buffer overflow
No Freezing (infinite loop, memory leaks)
No stacktraces
Immutable variables
Exceptions catching
Closing resources (files, streams, ...)
Input validation
No deprecates
No warnings
No eval
Tests
Unit tests
Functional tests
Coverage > 80%
CI/CD tools
Versioning
Git repo
Many small commits
Good commit messages
.gitignore
Score: 0/82 (0%)
Reset
Print
